fix: resolve NameError for undefined 'card_number' in identify_json#3
Open
fix: resolve NameError for undefined 'card_number' in identify_json#3
Conversation
…ndpoint (Closes stayforge/Stayforge_Networks_Access#14)
The identify_json function parameter is 'card' (a CardQuery object), but line 64
referenced the undefined variable 'card_number'. Changed to 'card.number' to
correctly access the number field from the CardQuery model.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
NameError: name 'card_number' is not definedinrouter/identify.pyat line 64. Theidentify_jsonendpoint was referencing an undefined variablecard_numberinstead of accessingcard.numberfrom theCardQueryparameter.Root Cause
The
identify_jsonfunction receives acard: CardQueryparameter, but the call toverify_cardon line 64 passedcard_number(an undefined variable) instead ofcard.number. This was likely caused by a refactoring where the parameter was renamed fromcard_numberto aCardQueryobject but the reference inside the function body was not updated.Changes
card_number=card_numbertocard_number=card.numberinrouter/identify.pyline 64Testing
CardQuerymodel has anumberfield (defined insrc/card.pyline 98-99)verify_cardexpects acard_number: strparameter (line 18)numberfrom theCardQueryobject to pass toverify_cardCloses stayforge/Stayforge_Networks_Access#14